• Heschi Kreinick's avatar
    cmd/link: don't create go.info symbols for non-Go functions · 6d7db25e
    Heschi Kreinick authored
    In writelines the linker uses various auxiliary information about a
    function to create its line table entries. (It also does some unrelated
    stuff, but never mind.) There's no reason to do this for non-Go
    functions, so it bails out if the symbol has no FuncInfo.
    
    However, it does so *after* it looks up (and implicitly creates!) the
    go.info symbol for the function, which doesn't make sense and risks
    creating duplicate symbols for static C functions. Move the check up so
    that it doesn't do that.
    
    Since non-Go functions can't reference Go types, there shouldn't be any
    relocations to type info DIEs that need to be built, so there should be
    no harm not doing that.
    
    I wanted to change the Lookup to an ROLookup but that broke the
    shared-mode tests with an inscrutable error.
    
    No test. It seems too specific to worry about, but if someone disagrees
    I can figure something out.
    
    Fixes #21566
    
    Change-Id: I61f03b7c504a3bf1c4245a8811795b6303469e91
    Reviewed-on: https://go-review.googlesource.com/58630Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    6d7db25e
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...