• Matthew Dempsky's avatar
    cmd/compile: eliminate dead code in walkappend · 75a22d0d
    Matthew Dempsky authored
    The IsStruct case is meant to handle cases like append(f()) where f's
    result parameters are something like ([]int, int, int). However, at
    this point in the compiler we've already rewritten append(f()) into
    "tmp1, tmp2, tmp3 := f(); append(tmp1, tmp2, tmp3)".
    
    As further evidence, the t.Elem() is not a valid method call for a
    struct type anyway, which would trigger the Fatalf call in Type.Elem
    if this code was ever hit.
    
    Change-Id: Ia066f93df66ee3fadc9a9a0f687be7b5263af163
    Reviewed-on: https://go-review.googlesource.com/21427
    Run-TryBot: Matthew Dempsky <mdempsky@google.com>
    Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    75a22d0d
Name
Last commit
Last update
.github Loading commit data...
api Loading commit data...
doc Loading commit data...
lib/time Loading commit data...
misc Loading commit data...
src Loading commit data...
test Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS Loading commit data...
LICENSE Loading commit data...
PATENTS Loading commit data...
README.md Loading commit data...
favicon.ico Loading commit data...
robots.txt Loading commit data...