• Michael Anthony Knyszek's avatar
    runtime: scavenge memory upon allocating from scavenged memory · 8e093e7a
    Michael Anthony Knyszek authored
    Because scavenged and unscavenged spans no longer coalesce, memory that
    is freed no longer has a high likelihood of being re-scavenged. As a
    result, if an application is allocating at a fast rate, it may work fast
    enough to undo all the scavenging work performed by the runtime's
    current scavenging mechanisms. This behavior is exacerbated by the
    global best-fit allocation policy the runtime uses, since scavenged
    spans are just as likely to be chosen as unscavenged spans on average.
    
    To remedy that, we treat each allocation of scavenged space as a heap
    growth, and scavenge other memory to make up for the allocation.
    
    This change makes performance of the runtime slightly worse, as now
    we're scavenging more often during allocation. The regression is
    particularly obvious with the garbage benchmark (3%) but most of the Go1
    benchmarks are within the margin of noise. A follow-up change should
    help.
    
    Garbage: https://perf.golang.org/search?q=upload:20190131.3
    Go1:     https://perf.golang.org/search?q=upload:20190131.2
    
    Updates #14045.
    
    Change-Id: I44a7e6586eca33b5f97b6d40418db53a8a7ae715
    Reviewed-on: https://go-review.googlesource.com/c/159500Reviewed-by: 's avatarAustin Clements <austin@google.com>
    8e093e7a
Name
Last commit
Last update
.github Loading commit data...
api Loading commit data...
doc Loading commit data...
lib/time Loading commit data...
misc Loading commit data...
src Loading commit data...
test Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS Loading commit data...
LICENSE Loading commit data...
PATENTS Loading commit data...
README.md Loading commit data...
favicon.ico Loading commit data...
robots.txt Loading commit data...