• Michael Anthony Knyszek's avatar
    runtime: scavenge memory upon allocating from scavenged memory · 8e093e7a
    Michael Anthony Knyszek authored
    Because scavenged and unscavenged spans no longer coalesce, memory that
    is freed no longer has a high likelihood of being re-scavenged. As a
    result, if an application is allocating at a fast rate, it may work fast
    enough to undo all the scavenging work performed by the runtime's
    current scavenging mechanisms. This behavior is exacerbated by the
    global best-fit allocation policy the runtime uses, since scavenged
    spans are just as likely to be chosen as unscavenged spans on average.
    
    To remedy that, we treat each allocation of scavenged space as a heap
    growth, and scavenge other memory to make up for the allocation.
    
    This change makes performance of the runtime slightly worse, as now
    we're scavenging more often during allocation. The regression is
    particularly obvious with the garbage benchmark (3%) but most of the Go1
    benchmarks are within the margin of noise. A follow-up change should
    help.
    
    Garbage: https://perf.golang.org/search?q=upload:20190131.3
    Go1:     https://perf.golang.org/search?q=upload:20190131.2
    
    Updates #14045.
    
    Change-Id: I44a7e6586eca33b5f97b6d40418db53a8a7ae715
    Reviewed-on: https://go-review.googlesource.com/c/159500Reviewed-by: 's avatarAustin Clements <austin@google.com>
    8e093e7a
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testdata Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...