• Ilya Tocar's avatar
    cmd/compile/internal/ssa: don't spill register offsets on amd64 · 9916feed
    Ilya Tocar authored
    Transform (ADDQconst SP) into (LEA SP), because lea is rematerializeable,
    so this avoids register spill. We can't mark ADDQconst as rematerializeable,
    because it clobbers flags. This makes go binary ~2kb smaller.
    
    For reference here is generated code for function from bug report.
    Before:
            CALL    "".g(SB)
            MOVBLZX (SP), AX
            LEAQ    8(SP), DI
            TESTB   AX, AX
            JEQ     15
            MOVQ    "".p(SP), SI
            DUFFCOPY        $196
            MOVQ    $0, (SP)
            PCDATA  $0, $1
            CALL    "".h(SB)
            RET
            MOVQ    DI, ""..autotmp_2-8(SP) // extra spill
            PCDATA  $0, $2
            CALL    "".g(SB)
            MOVQ    ""..autotmp_2-8(SP), DI // extra register fill
            MOVQ    "".p(SP), SI
            DUFFCOPY        $196
            MOVQ    $1, (SP)
            PCDATA  $0, $1
            CALL    "".h(SB)
            JMP     14
            END
    
    After:
            CALL    "".g(SB)
            MOVBLZX (SP), AX
            TESTB   AX, AX
            JEQ     15
            LEAQ    8(SP), DI
            MOVQ    "".p(SP), SI
            DUFFCOPY        $196
            MOVQ    $0, (SP)
            PCDATA  $0, $1
            CALL    "".h(SB)
            RET
            PCDATA  $0, $0  // no spill
            CALL    "".g(SB)
            LEAQ    8(SP), DI // rematerialized instead
            MOVQ    "".p(SP), SI
            DUFFCOPY        $196
            MOVQ    $1, (SP)
            PCDATA  $0, $1
            CALL    "".h(SB)
            JMP     14
            END
    
    Fixes #22947
    
    Change-Id: I8f33b860dc6c8828373477171b172ca2ce30074f
    Reviewed-on: https://go-review.googlesource.com/81815
    Run-TryBot: Ilya Tocar <ilya.tocar@intel.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarKeith Randall <khr@golang.org>
    9916feed
Name
Last commit
Last update
.github Loading commit data...
api Loading commit data...
doc Loading commit data...
lib/time Loading commit data...
misc Loading commit data...
src Loading commit data...
test Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS Loading commit data...
LICENSE Loading commit data...
PATENTS Loading commit data...
README.md Loading commit data...
favicon.ico Loading commit data...
robots.txt Loading commit data...