• Ilya Tocar's avatar
    cmd/compile/internal/ssa: don't spill register offsets on amd64 · 9916feed
    Ilya Tocar authored
    Transform (ADDQconst SP) into (LEA SP), because lea is rematerializeable,
    so this avoids register spill. We can't mark ADDQconst as rematerializeable,
    because it clobbers flags. This makes go binary ~2kb smaller.
    
    For reference here is generated code for function from bug report.
    Before:
            CALL    "".g(SB)
            MOVBLZX (SP), AX
            LEAQ    8(SP), DI
            TESTB   AX, AX
            JEQ     15
            MOVQ    "".p(SP), SI
            DUFFCOPY        $196
            MOVQ    $0, (SP)
            PCDATA  $0, $1
            CALL    "".h(SB)
            RET
            MOVQ    DI, ""..autotmp_2-8(SP) // extra spill
            PCDATA  $0, $2
            CALL    "".g(SB)
            MOVQ    ""..autotmp_2-8(SP), DI // extra register fill
            MOVQ    "".p(SP), SI
            DUFFCOPY        $196
            MOVQ    $1, (SP)
            PCDATA  $0, $1
            CALL    "".h(SB)
            JMP     14
            END
    
    After:
            CALL    "".g(SB)
            MOVBLZX (SP), AX
            TESTB   AX, AX
            JEQ     15
            LEAQ    8(SP), DI
            MOVQ    "".p(SP), SI
            DUFFCOPY        $196
            MOVQ    $0, (SP)
            PCDATA  $0, $1
            CALL    "".h(SB)
            RET
            PCDATA  $0, $0  // no spill
            CALL    "".g(SB)
            LEAQ    8(SP), DI // rematerialized instead
            MOVQ    "".p(SP), SI
            DUFFCOPY        $196
            MOVQ    $1, (SP)
            PCDATA  $0, $1
            CALL    "".h(SB)
            JMP     14
            END
    
    Fixes #22947
    
    Change-Id: I8f33b860dc6c8828373477171b172ca2ce30074f
    Reviewed-on: https://go-review.googlesource.com/81815
    Run-TryBot: Ilya Tocar <ilya.tocar@intel.com>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: 's avatarKeith Randall <khr@golang.org>
    9916feed
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...