• David Glasser's avatar
    net/http: don't hang if RemoteAddr() blocks · b58515ba
    David Glasser authored
    The PROXY protocol is supported by several proxy servers such as haproxy
    and Amazon ELB.  This protocol allows services running behind a proxy to
    learn the remote address of the actual client connecting to the proxy,
    by including a single textual line at the beginning of the TCP
    connection.
    http://www.haproxy.org/download/1.5/doc/proxy-protocol.txt
    
    There are several Go libraries for this protocol (such as
    https://github.com/armon/go-proxyproto), which operate by wrapping a
    net.Conn with an implementation whose RemoteAddr method reads the
    protocol line before returning. This means that RemoteAddr is a blocking
    call.
    
    Before this change, http.Serve called RemoteAddr from the main Accepting
    goroutine, not from the per-connection goroutine. This meant that it
    would not Accept another connection until RemoteAddr returned, which is
    not appropriate if RemoteAddr needs to do a blocking read from the
    socket first.
    
    Fixes #12943.
    
    Change-Id: I1a242169e6e4aafd118b794e7c8ac45d0d573421
    Reviewed-on: https://go-review.googlesource.com/15835Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    b58515ba
Name
Last commit
Last update
..
cgi Loading commit data...
cookiejar Loading commit data...
fcgi Loading commit data...
httptest Loading commit data...
httputil Loading commit data...
internal Loading commit data...
pprof Loading commit data...
testdata Loading commit data...
client.go Loading commit data...
client_test.go Loading commit data...
cookie.go Loading commit data...
cookie_test.go Loading commit data...
doc.go Loading commit data...
example_test.go Loading commit data...
export_test.go Loading commit data...
filetransport.go Loading commit data...
filetransport_test.go Loading commit data...
fs.go Loading commit data...
fs_test.go Loading commit data...
header.go Loading commit data...
header_test.go Loading commit data...
http_test.go Loading commit data...
jar.go Loading commit data...
lex.go Loading commit data...
lex_test.go Loading commit data...
main_test.go Loading commit data...
npn_test.go Loading commit data...
proxy_test.go Loading commit data...
race.go Loading commit data...
range_test.go Loading commit data...
readrequest_test.go Loading commit data...
request.go Loading commit data...
request_test.go Loading commit data...
requestwrite_test.go Loading commit data...
response.go Loading commit data...
response_test.go Loading commit data...
responsewrite_test.go Loading commit data...
serve_test.go Loading commit data...
server.go Loading commit data...
sniff.go Loading commit data...
sniff_test.go Loading commit data...
status.go Loading commit data...
transfer.go Loading commit data...
transfer_test.go Loading commit data...
transport.go Loading commit data...
transport_test.go Loading commit data...
triv.go Loading commit data...