• Kirill Smelkov's avatar
    cmd/compile: Show arch/os when something in TestAssembly fails · e2948f7e
    Kirill Smelkov authored
    It is not always obvious from the first glance when looking at
    TestAssembly failure in which context the code was generated. For
    example x86 and x86-64 are similar, and those of us who do not work with
    assembly every day can even take s390x version as something similar to x86.
    
    So when something fails lets print the whole test context - this
    includes os and arch which were previously missing. An example failure:
    
    before:
    
    --- FAIL: TestAssembly (40.48s)
            asm_test.go:46: expected:       MOVWZ   \(.*\),
                    go:
                    import "encoding/binary"
                    func f(b []byte) uint32 {
                            return binary.LittleEndian.Uint32(b)
                    }
    
                    asm:"".f t=1 size=160 args=0x20 locals=0x0
    		...
    
    after:
    
    --- FAIL: TestAssembly (40.43s)
            asm_test.go:46: linux/s390x: expected:  MOVWZ   \(.*\),
                    go:
                    import "encoding/binary"
                    func f(b []byte) uint32 {
                            return binary.LittleEndian.Uint32(b)
                    }
    
                    asm:"".f t=1 size=160 args=0x20 locals=0x0
    
    Motivated-by: #18946#issuecomment-279491071
    
    Change-Id: I61089ceec05da7a165718a7d69dec4227dd0e993
    Reviewed-on: https://go-review.googlesource.com/36881Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    e2948f7e
Name
Last commit
Last update
.github Loading commit data...
api Loading commit data...
doc Loading commit data...
lib/time Loading commit data...
misc Loading commit data...
src Loading commit data...
test Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS Loading commit data...
LICENSE Loading commit data...
PATENTS Loading commit data...
README.md Loading commit data...
favicon.ico Loading commit data...
robots.txt Loading commit data...