• Kirill Smelkov's avatar
    cmd/compile: Show arch/os when something in TestAssembly fails · e2948f7e
    Kirill Smelkov authored
    It is not always obvious from the first glance when looking at
    TestAssembly failure in which context the code was generated. For
    example x86 and x86-64 are similar, and those of us who do not work with
    assembly every day can even take s390x version as something similar to x86.
    
    So when something fails lets print the whole test context - this
    includes os and arch which were previously missing. An example failure:
    
    before:
    
    --- FAIL: TestAssembly (40.48s)
            asm_test.go:46: expected:       MOVWZ   \(.*\),
                    go:
                    import "encoding/binary"
                    func f(b []byte) uint32 {
                            return binary.LittleEndian.Uint32(b)
                    }
    
                    asm:"".f t=1 size=160 args=0x20 locals=0x0
    		...
    
    after:
    
    --- FAIL: TestAssembly (40.43s)
            asm_test.go:46: linux/s390x: expected:  MOVWZ   \(.*\),
                    go:
                    import "encoding/binary"
                    func f(b []byte) uint32 {
                            return binary.LittleEndian.Uint32(b)
                    }
    
                    asm:"".f t=1 size=160 args=0x20 locals=0x0
    
    Motivated-by: #18946#issuecomment-279491071
    
    Change-Id: I61089ceec05da7a165718a7d69dec4227dd0e993
    Reviewed-on: https://go-review.googlesource.com/36881Reviewed-by: 's avatarBrad Fitzpatrick <bradfitz@golang.org>
    Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    e2948f7e
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
context Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
plugin Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor/golang_org/x Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
cmp.bash Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
naclmake.bash Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...