• Russ Cox's avatar
    cmd/go: use GOPATH order for compile -I and link -L options · ee451770
    Russ Cox authored
    Given GOPATH=p1:p2 and source code of just the right form,
    the go command could previously end up invoking the compiler
    with -I p2 -I p1 or the linker with -L p2 -L p1, so that
    compiled packages in p2 incorrectly shadowed packages in p1.
    If foo were in both p1 and p2 and the compilation of bar
    were such that the -I and -L options were inverted in this way,
    then
    
    	GOPATH=p2 go install foo
    	GOPATH=p1:p2 go install bar
    
    would get the p2 copy of foo instead of the (expected) p1 copy of foo.
    
    This manifested in real usage in a few different ways, but in all
    the root cause was that the -I or -L option sequence did not
    match GOPATH.
    
    Make it match GOPATH.
    
    Fixes #14176 (second report).
    Fixes #14192.
    Related but less common issue #14271 not fixed.
    
    Change-Id: I9c0f69042bb2bf92c9fc370535da2c60a1187d30
    Reviewed-on: https://go-review.googlesource.com/19385Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    Run-TryBot: Russ Cox <rsc@golang.org>
    ee451770
Name
Last commit
Last update
api Loading commit data...
doc Loading commit data...
lib/time Loading commit data...
misc Loading commit data...
src Loading commit data...
test Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
CONTRIBUTING.md Loading commit data...
CONTRIBUTORS Loading commit data...
LICENSE Loading commit data...
PATENTS Loading commit data...
README.md Loading commit data...
favicon.ico Loading commit data...
robots.txt Loading commit data...