• Russ Cox's avatar
    cmd/go: use GOPATH order for compile -I and link -L options · ee451770
    Russ Cox authored
    Given GOPATH=p1:p2 and source code of just the right form,
    the go command could previously end up invoking the compiler
    with -I p2 -I p1 or the linker with -L p2 -L p1, so that
    compiled packages in p2 incorrectly shadowed packages in p1.
    If foo were in both p1 and p2 and the compilation of bar
    were such that the -I and -L options were inverted in this way,
    then
    
    	GOPATH=p2 go install foo
    	GOPATH=p1:p2 go install bar
    
    would get the p2 copy of foo instead of the (expected) p1 copy of foo.
    
    This manifested in real usage in a few different ways, but in all
    the root cause was that the -I or -L option sequence did not
    match GOPATH.
    
    Make it match GOPATH.
    
    Fixes #14176 (second report).
    Fixes #14192.
    Related but less common issue #14271 not fixed.
    
    Change-Id: I9c0f69042bb2bf92c9fc370535da2c60a1187d30
    Reviewed-on: https://go-review.googlesource.com/19385Reviewed-by: 's avatarIan Lance Taylor <iant@golang.org>
    Run-TryBot: Russ Cox <rsc@golang.org>
    ee451770
Name
Last commit
Last update
..
archive Loading commit data...
bufio Loading commit data...
builtin Loading commit data...
bytes Loading commit data...
cmd Loading commit data...
compress Loading commit data...
container Loading commit data...
crypto Loading commit data...
database/sql Loading commit data...
debug Loading commit data...
encoding Loading commit data...
errors Loading commit data...
expvar Loading commit data...
flag Loading commit data...
fmt Loading commit data...
go Loading commit data...
hash Loading commit data...
html Loading commit data...
image Loading commit data...
index/suffixarray Loading commit data...
internal Loading commit data...
io Loading commit data...
log Loading commit data...
math Loading commit data...
mime Loading commit data...
net Loading commit data...
os Loading commit data...
path Loading commit data...
reflect Loading commit data...
regexp Loading commit data...
runtime Loading commit data...
sort Loading commit data...
strconv Loading commit data...
strings Loading commit data...
sync Loading commit data...
syscall Loading commit data...
testing Loading commit data...
text Loading commit data...
time Loading commit data...
unicode Loading commit data...
unsafe Loading commit data...
vendor Loading commit data...
Make.dist Loading commit data...
all.bash Loading commit data...
all.bat Loading commit data...
all.rc Loading commit data...
androidtest.bash Loading commit data...
bootstrap.bash Loading commit data...
buildall.bash Loading commit data...
clean.bash Loading commit data...
clean.bat Loading commit data...
clean.rc Loading commit data...
iostest.bash Loading commit data...
make.bash Loading commit data...
make.bat Loading commit data...
make.rc Loading commit data...
nacltest.bash Loading commit data...
race.bash Loading commit data...
race.bat Loading commit data...
run.bash Loading commit data...
run.bat Loading commit data...
run.rc Loading commit data...