Commit ddbc69e0 authored by Brad Fitzpatrick's avatar Brad Fitzpatrick

http2: fix broken test after ConfigureServer change

ConfigureServer now returns an error if your config is wrong. It
doesn't attempt to fix it for you. Adjust this test accordingly.

Change-Id: Ie3de878ff58cef454de0ec9ab1a10459ca0ddd2d
Reviewed-on: https://go-review.googlesource.com/16061Reviewed-by: 's avatarAdam Langley <agl@golang.org>
parent 42ad5085
...@@ -2115,12 +2115,9 @@ func TestServer_Advertises_Common_Cipher(t *testing.T) { ...@@ -2115,12 +2115,9 @@ func TestServer_Advertises_Common_Cipher(t *testing.T) {
c.CipherSuites = []uint16{requiredSuite} c.CipherSuites = []uint16{requiredSuite}
}, func(ts *httptest.Server) { }, func(ts *httptest.Server) {
var srv *http.Server = ts.Config var srv *http.Server = ts.Config
// Have the server configured with one specific cipher suite // Have the server configured with no specific cipher suites.
// which is banned. This tests that ConfigureServer ends up // This tests that Go's defaults include the required one.
// adding the good one to this list. srv.TLSConfig = nil
srv.TLSConfig = &tls.Config{
CipherSuites: []uint16{tls.TLS_RSA_WITH_AES_128_CBC_SHA}, // just a banned one
}
}) })
defer st.Close() defer st.Close()
st.greet() st.greet()
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment