Commits · 197eb8f7c3703e46d3fc351d277e03cd3b413fbc · go / golang

15 Dec, 2011 30 commits

govet: add checking for printf verbs · 197eb8f7

Rob Pike authored Dec 15, 2011

Also fix the errors it catches.

Fixes #1654.

R=rsc
CC=golang-dev
https://golang.org/cl/5489060

197eb8f7

godoc: Allow examples for methods. · cb7d6e37

Volker Dobler authored Dec 15, 2011

An example for a method M() of type T can be written as
func ExampleT_M() { ... }.
To differentiate between multiple examples for one function, type or
method a suffix with a lowercase start may be appended to the name
of the example function, e.g. ExampleFoo_basicUsage.

Fixes #2465.

R=golang-dev, adg, r, rsc, duperray.olivier, r
CC=golang-dev
https://golang.org/cl/5440100

cb7d6e37

testing: trim spaces before comparing example output · 9834a25d
Andrew Gerrand authored Dec 15, 2011
```
bytes: add two Buffer examples

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5490048
```
9834a25d

html: handle end tags in foreign objects. · a369004e

Nigel Tao authored Dec 15, 2011

I'm not 100% sure I get all the corner cases right, for end tags, but
I'll let the test suite smoke it out.

Pass tests10.dat, test 1:
<!DOCTYPE html><svg></svg><![CDATA[a]]>

| <!DOCTYPE html>
| <html>
|   <head>
|   <body>
|     <svg svg>
|     <!-- [CDATA[a]] -->

Also pass tests through test 5:
<!DOCTYPE html><body><table><svg></svg></table>

R=andybalholm
CC=golang-dev
https://golang.org/cl/5495044

a369004e

go/printer, gofmt: don't write too many newlines · 9f65e99a

Robert Griesemer authored Dec 15, 2011

In some rare cases, gofmt would accept more than the maximum
number of empty lines (1) between source code snippets.

The actual change is in printer.go, lines 773-775; the rest
is some minor restructuring.

Applied gofmt -w src misc .

Fixes #2387.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5496047

9f65e99a

exp/ssh: simplify Stdin/out/errPipe methods · 52c8107a

Dave Cheney authored Dec 15, 2011

If a Pipe method is called, return the underlying
reader/writer from session.clientChan, bypassing the
io.Copy and io.Pipe harness.

StdoutPipe and StderrPipe now return an io.Reader not
an io.ReadCloser as SSH cannot signal the close of the
local reader to the remote process.

R=rsc, agl, gustav.paul, cw
CC=golang-dev
https://golang.org/cl/5493047

52c8107a

govet: divide the program into one file per vetting suite · b618f326

Rob Pike authored Dec 15, 2011

Just a rearrangement except for a couple of new functions
and names so govet.go can have all the generic walk routines.

R=rsc
CC=golang-dev
https://golang.org/cl/5489058

b618f326

fmt: speed up floating point print, clean up some code · 04faa08c

Rob Pike authored Dec 15, 2011

%g down to two mallocs from four. Also a mild speedup.

fmt_test.BenchmarkSprintfFloat         3016         2703  -10.38%

Fixes #2557.

R=rsc
CC=golang-dev
https://golang.org/cl/5491054

04faa08c

json: use strconv.Append variants to avoid allocations in encoding · 29264c6f

Brad Fitzpatrick authored Dec 15, 2011

Before/after, best of 3:
json.BenchmarkCodeEncoder  10  183495300 ns/op  10.58 MB/s
->
json.BenchmarkCodeEncoder  10  133025100 ns/op  14.59 MB/s

But don't get too excited about this.  These benchmarks, while
stable at any point of time, fluctuate wildly with any line of
code added or removed anywhere in the path due to stack splitting
issues.

It's currently much faster, though, and this is the API that
doesn't allocate so should always be faster in theory.

R=golang-dev, dsymonds, rsc, r, gri
CC=golang-dev
https://golang.org/cl/5411052

29264c6f

go: help messages for 'go test' · 143f3b38

Russ Cox authored Dec 15, 2011

The plan is to make 'go test' replace gotest entirely, so it
cannot refer to gotest's godoc.  Instead, copy gotest's
documentation in as three different help messages:
'go help test', 'go help testflag', and 'go help testfunc'.

R=r
CC=golang-dev
https://golang.org/cl/5491048

143f3b38

go spec: be precise about newlines · 11b7c89b

Robert Griesemer authored Dec 15, 2011

Several places mentioned tokens spanning "multiple lines"
which is not a well-defined term in the spec; newline is.

R=golang-dev, rsc, r
CC=golang-dev
https://golang.org/cl/5490046

11b7c89b

go/scanner: strip CRs from raw literals · fb6ffd8f
Robert Griesemer authored Dec 15, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5495049
```
fb6ffd8f
more tags for go/build · fd1f1096
Russ Cox authored Dec 15, 2011
```
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5490047
```
fd1f1096

sql: add Rows.Columns · ea51dd23

Brad Fitzpatrick authored Dec 15, 2011

Also, fix package name in error messages.

Fixes #2453

R=rsc
CC=golang-dev
https://golang.org/cl/5483088

ea51dd23

json: some tests to demonstrate bad error messages · f89b5746
Brad Fitzpatrick authored Dec 15, 2011
```
Not a fix yet (help wanted), but part of Issue 2331

R=rsc
CC=golang-dev
https://golang.org/cl/5490043
```
f89b5746

os: make compatible with go/build · 1b82e03a

Russ Cox authored Dec 15, 2011

It is probably a mistake to have these here at all -
os is supposed to be portable - but this only fixes
the build issue.

R=golang-dev, r, r, iant
CC=golang-dev
https://golang.org/cl/5487073

1b82e03a

test/bench/go1: first draft of Go 1 benchmark suite · 6e887555

Russ Cox authored Dec 15, 2011

I have included a few important microbenchmarks,
but the overall intent is to have mostly end-to-end
benchmarks timing real world operations.

The jsondata.go file is a summary of agl's
activity in various open source repositories.
It gets used as test data for many of the benchmarks.

Everything links into one binary (even the test data)
so that it is easy to run the benchmarks on many
computers: there is just one file to copy around.

R=golang-dev, r, bradfitz, adg, r
CC=golang-dev
https://golang.org/cl/5484071

6e887555

os: OS-dependent bits to support NetBSD. · d10126a6
Christopher Nielsen authored Dec 15, 2011
```
R=golang-dev, jsing
CC=golang-dev
https://golang.org/cl/5482068
```
d10126a6
gc: inlining, allow empty bodies, fix _ arguments. · 7e6890a6
Luuk van Dijk authored Dec 15, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5487077
```
7e6890a6
gc: omit argument names from function types in error messages · 5b2f8d96
Luuk van Dijk authored Dec 15, 2011
```
Fixes #2563

R=rsc
CC=golang-dev
https://golang.org/cl/5495047
```
5b2f8d96

gc: better loopdepth analysis for labels · 9bf34786

Luuk van Dijk authored Dec 15, 2011

This avoids degraded performance caused by extra labels
emitted by inlining (breaking strconv ftoa alloc count unittest) and is better in any case.

R=rsc
CC=golang-dev
https://golang.org/cl/5483071

9bf34786

time: new AddDate method · cebf55dc
Roger Peppe authored Dec 15, 2011
```
R=rsc
CC=golang-dev
https://golang.org/cl/5465044
```
cebf55dc

exp/ssh: rename ClientAuthPublicKey helper ClientAuthKeyring · fc6df2fd

Dave Cheney authored Dec 15, 2011

Also, rename ServerConfig.PubKeyCallback to PublicKeyCallback.

R=rsc, agl
CC=golang-dev
https://golang.org/cl/5477059

fc6df2fd

gc: implement and test \r in raw strings · 17264df1
Russ Cox authored Dec 15, 2011
```
For issue 680.

R=ken2
CC=golang-dev
https://golang.org/cl/5492046
```
17264df1
doc: remove an errant dot. · c5fce331
Andrew Gerrand authored Dec 15, 2011
```
Curses!

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5489048
```
c5fce331
tag weekly.2011-12-14 · 3621f2d3
Andrew Gerrand authored Dec 15, 2011
```
R=r
CC=golang-dev
https://golang.org/cl/5489046
```
3621f2d3
weekly.2011-12-14 · 3388e9f6
Andrew Gerrand authored Dec 15, 2011
```
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5494045
```
3388e9f6

spec: skip carriage returns in raw literals · c26ca912

Rob Pike authored Dec 15, 2011

This change guarantees that whether the line ending convention
when the source is created includes carriage returns is irrelevant
to the value of the string. See issue 680.

The compilers do not yet implement this.

R=golang-dev, adg, r, gri, rsc, iant
CC=golang-dev
https://golang.org/cl/5491043

c26ca912

go: implement build, install, run · 2ad8a9c5

Russ Cox authored Dec 15, 2011

clean is gone; all the intermediate files are created
in a temporary tree that is wiped when the command ends.

Not using go/build's Script because it is not well aligned
with this API.  The various builder methods are copied from
go/build and adapted.  Probably once we delete goinstall
we can delete the Script API too.

R=rogpeppe, adg, adg
CC=golang-dev
https://golang.org/cl/5483069

2ad8a9c5

fmt: don't recur if String method (etc.) misbehaves · 24e9683a
Rob Pike authored Dec 15, 2011
```
Fixes #2555.

R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/5486076
```
24e9683a

14 Dec, 2011 10 commits

html: don't leave "in column group" mode when ignoring a token · 85fdd68b

Andrew Balholm authored Dec 14, 2011

Pass tests6.dat, test 26:
foo<col>

| <col>

Also pass tests through test 35:
<table><tr><div><td>

R=nigeltao
CC=golang-dev
https://golang.org/cl/5482074

85fdd68b

cgo: add basic gccgo support. · 076ebed0
Rémy Oudompheng authored Dec 14, 2011
```
R=rsc, iant
CC=golang-dev, remy
https://golang.org/cl/5485070
```
076ebed0
5c, 6c, 8c: support 64-bit switch value · d89b7173
Anthony Martin authored Dec 14, 2011
```
For real this time. :-)

R=rsc, ken
CC=golang-dev
https://golang.org/cl/5486061
```
d89b7173

gzip: Convert between Latin-1 and Unicode · 8fbeb945

Vadim Vygonets authored Dec 14, 2011

I realize I didn't send the tests in last time.  Anyway, I added
a test that knows too much about the package's internal structure,
and I'm not sure whether it's the right thing to do.

Vadik.

R=bradfitz, rsc, go.peter.90
CC=golang-dev
https://golang.org/cl/5450073

8fbeb945

net/smtp: add CRAM-MD5 authentication · 58b97a29
Vadim Vygonets authored Dec 14, 2011
```
R=golang-dev, edsrzf, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5451087
```
58b97a29
A+C: Vadim Vygonets (individual CLA) · f454dee4
Russ Cox authored Dec 14, 2011
```
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5482073
```
f454dee4
misc/osx: Rename profile.go to profile_go to avoid confusing scripts · 4e066e41
Scott Lawrence authored Dec 14, 2011
```
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5472043
```
4e066e41

html/template: define the FuncMap type locally · 1402d1a6

Rob Pike authored Dec 14, 2011

This redefinition means that the public signature of html/template
does not refer to text/template.

Fixes #2546.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5487083

1402d1a6

gotest: use build.DefaultContext.GOARCH · 78821616

Robert Hencke authored Dec 14, 2011

Fixes https://golang.org/cl/5480060/#msg4

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5485051

78821616

http: fix failing Transport HEAD request with gzip-looking response · 22dafc9b

Brad Fitzpatrick authored Dec 14, 2011

We only want to attempt to un-gzip if there's a body (not in
response to a HEAD)

This was accidentally passing before, but revealed to be broken
when c3c6e72d7cc went in.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5477093

22dafc9b