- 09 Apr, 2014 15 commits
-
-
Russ Cox authored
Cuts the number of calls from 6 to 2 in the non-debug case. LGTM=iant R=golang-codereviews, iant CC=0intro, aram, golang-codereviews, khr https://golang.org/cl/86040043
-
Russ Cox authored
Suggested in comments on CL 85740043. LGTM=aram R=golang-codereviews, aram CC=dave, golang-codereviews, r https://golang.org/cl/85990044
-
Russ Cox authored
TBR=iant CC=golang-codereviews https://golang.org/cl/86030043
-
Jan Ziak authored
LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/85890043
-
Jan Ziak authored
Fixes #6889 LGTM=rsc R=gri, rsc CC=golang-codereviews https://golang.org/cl/85080044
-
Jan Ziak authored
Fixes #7538 LGTM=rsc R=gri, rsc CC=golang-codereviews https://golang.org/cl/85040045
-
Rob Pike authored
1) The code to catch an exception marked the template as escaped when it was not yet, which caused subsequent executions of the template to not escape properly. 2) ensurePipelineContains needs to handled Field as well as Identifier nodes. Fixes #7379. LGTM=mikesamuel R=mikesamuel CC=golang-codereviews https://golang.org/cl/85240043
-
Rob Pike authored
LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/85840043
-
David du Colombier authored
Getenv() should not call malloc when called from gotraceback(). Instead, we return a static buffer in this case, with enough room to hold the longest value. LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/85680043
-
Rob Pike authored
LGTM=rsc R=rsc, bradfitz CC=golang-codereviews https://golang.org/cl/85740043
-
Brad Fitzpatrick authored
LGTM=r R=r CC=golang-codereviews https://golang.org/cl/85760043
-
Russ Cox authored
On Plan 9 gotraceback calls getenv calls malloc, and we gotraceback on every call to gentraceback, which happens during garbage collection. Honestly I don't even know how this works on Plan 9. I suspect it does not, and that we are getting by because no one has tried to run with $GOTRACEBACK set at all. This will speed up all the other systems by epsilon, since they won't call getenv and atoi repeatedly. LGTM=bradfitz R=golang-codereviews, bradfitz, 0intro CC=golang-codereviews https://golang.org/cl/85430046
-
Rick Arnold authored
Add a $Context variable to the template so that the build.Context values such as BuildTags can be accessed. Fixes #6666. LGTM=adg, rsc R=golang-codereviews, gobot, adg, rsc CC=golang-codereviews https://golang.org/cl/72770043
-
Carl Chatfield authored
Short circuit for calling values funcs by MakeFunc was placed before variadic arg rearrangement code in reflect.call. Fixes #7534. LGTM=khr R=golang-codereviews, bradfitz, khr, rsc CC=golang-codereviews https://golang.org/cl/75370043
-
Russ Cox authored
Generated by addca. R=gobot CC=golang-codereviews https://golang.org/cl/85820043
-
- 08 Apr, 2014 14 commits
-
-
Rob Pike authored
LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/85720043
-
Adam Langley authored
Now that we have a constant-time P-256 implementation, it's worth paying more attention elsewhere. The inversion of k in (EC)DSA was using Euclid's algorithm which isn't constant-time. This change switches to Fermat's algorithm, which is much better. However, it's important to note that math/big itself isn't constant time and is using a 4-bit window for exponentiation with variable memory access patterns. (Since math/big depends quite deeply on its values being in minimal (as opposed to fixed-length) represetation, perhaps crypto/elliptic should grow a constant-time implementation of exponentiation in the scalar field.) R=bradfitz Fixes #7652. LGTM=rsc R=golang-codereviews, bradfitz, rsc CC=golang-codereviews https://golang.org/cl/82740043
-
Rob Pike authored
LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/85660043
-
Rob Pike authored
LGTM=dvyukov, iant, rsc R=golang-codereviews, dvyukov, iant, rsc CC=golang-codereviews https://golang.org/cl/85250043
-
Robert Griesemer authored
Permit paired parentheses in URLs such as: http://en.wikipedia.org/wiki/Camellia_(cipher) Fixes #5043. LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/85610043
-
Josh Bleecher Snyder authored
Fixes #6836. LGTM=rsc R=golang-codereviews, rsc, r, mike CC=golang-codereviews https://golang.org/cl/33140043
-
Alexander Zhavnerchik authored
Fixes #7614. LGTM=rsc R=golang-codereviews, r, rsc, dan.kortschak, applezinc CC=golang-codereviews https://golang.org/cl/79210044
-
Russ Cox authored
Generated by addca. R=gobot CC=golang-codereviews https://golang.org/cl/85490043
-
Russ Cox authored
Given type Outer struct { *Inner ... } the compiler generates the implementation of (*Outer).M dispatching to the embedded Inner. The implementation is logically: func (p *Outer) M() { (p.Inner).M() } but since the only change here is the replacement of one pointer receiver with another, the actual generated code overwrites the original receiver with the p.Inner pointer and then jumps to the M method expecting the *Inner receiver. During reflect.Value.Call, we create an argument frame and the associated data structures to describe it to the garbage collector, populate the frame, call reflect.call to run a function call using that frame, and then copy the results back out of the frame. The reflect.call function does a memmove of the frame structure onto the stack (to set up the inputs), runs the call, and the memmoves the stack back to the frame structure (to preserve the outputs). Originally reflect.call did not distinguish inputs from outputs: both memmoves were for the full stack frame. However, in the case where the called function was one of these wrappers, the rewritten receiver is almost certainly a different type than the original receiver. This is not a problem on the stack, where we use the program counter to determine the type information and understand that during (*Outer).M the receiver is an *Outer while during (*Inner).M the receiver in the same memory word is now an *Inner. But in the statically typed argument frame created by reflect, the receiver is always an *Outer. Copying the modified receiver pointer off the stack into the frame will store an *Inner there, and then if a garbage collection happens to scan that argument frame before it is discarded, it will scan the *Inner memory as if it were an *Outer. If the two have different memory layouts, the collection will intepret the memory incorrectly. Fix by only copying back the results. Fixes #7725. LGTM=khr R=khr CC=dave, golang-codereviews https://golang.org/cl/85180043
-
Dmitriy Vyukov authored
It turns out there is a relatively common pattern that relies on inverted channel semaphore: gate := make(chan bool, N) for ... { // limit concurrency gate <- true go func() { foo(...) <-gate }() } // join all goroutines for i := 0; i < N; i++ { gate <- true } So handle synchronization on inverted semaphores with cap>1. Fixes #7718. LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/84880046
-
Ian Lance Taylor authored
This code tests linkmode == LinkExternal but is only invoked by the compiler/assembler, not the linker. Update #7164 LGTM=rsc R=rsc, dave CC=golang-codereviews https://golang.org/cl/85080043
-
Rob Pike authored
LGTM=bradfitz, alex.brainman R=golang-codereviews, bradfitz, alex.brainman CC=golang-codereviews https://golang.org/cl/85190043
-
Keith Randall authored
Defers generated from cgo lie to us about their argument layout. Mark those defers as not copyable. CL 83820043 contains an additional test for this code and should be checked in (and enabled) after this change is in. Fixes bug 7695. LGTM=rsc R=golang-codereviews, rsc CC=golang-codereviews https://golang.org/cl/84740043
-
Keith Randall authored
Iterate the right number of times in arrays and channels. Handle channels with zero-sized objects in them. Output longer type names if we have them. Compute argument offset correctly. LGTM=rsc R=golang-codereviews, rsc CC=golang-codereviews https://golang.org/cl/82980043
-
- 07 Apr, 2014 8 commits
-
-
Mikio Hara authored
Also makes ErrWriteToConnected more appropriate; it's used not only UDPConn operations but UnixConn operations. Update #4856 LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/84800044
-
Mikio Hara authored
The prefix was not uniformly applied and is probably better left off for using with OpError. Update #4856 LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/84660046
-
Albert Strasheim authored
LGTM=iant R=iant CC=golang-codereviews https://golang.org/cl/85070043
-
Brad Fitzpatrick authored
Takes advantage of CL 83740044, to optimize map[string] lookup from []byte key. Deletes code. No conditional check for gccgo, since Ian plans to add this to gccgo before GCC 4.10 (Go 1.3). benchmark old ns/op new ns/op delta BenchmarkReadMIMEHeader 6066 5086 -16.16% benchmark old allocs new allocs delta BenchmarkReadMIMEHeader 12 12 +0.00% benchmark old bytes new bytes delta BenchmarkReadMIMEHeader 1317 1317 +0.00% Update #3512 LGTM=rsc R=rsc, dave CC=golang-codereviews, iant https://golang.org/cl/84230043
-
Lucio De Re authored
Superficial inconsistencies that trigger warnings in Plan 9. Small enough to be considered trivial and seemingly benign outside of the Plan 9 environment. LGTM=iant R=golang-codereviews, 0intro, iant CC=golang-codereviews https://golang.org/cl/73460043
-
Dmitriy Vyukov authored
If an error happens on a connection, server goroutine can call b.Logf after benchmark finishes. So join both client and server goroutines. Update #7718 LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://golang.org/cl/84750047
-
Brad Fitzpatrick authored
Generated by addca. R=gobot CC=golang-codereviews https://golang.org/cl/84710045
-
Andrew Gerrand authored
LGTM=bradfitz R=bradfitz CC=golang-codereviews https://golang.org/cl/84920043
-
- 06 Apr, 2014 2 commits
-
-
Russ Cox authored
TBR=khr CC=golang-codereviews https://golang.org/cl/84570045
-
Alex Brainman authored
Fixes #7171 LGTM=iant R=golang-codereviews, iant CC=golang-codereviews https://golang.org/cl/84330043
-
- 04 Apr, 2014 1 commit
-
-
Keith Randall authored
Fixes #7547 LGTM=iant R=iant, khr CC=golang-codereviews https://golang.org/cl/84470046
-